Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Nerd Fonts 3.2.1 #85

Merged
merged 3 commits into from
May 2, 2024
Merged

Adapt to Nerd Fonts 3.2.1 #85

merged 3 commits into from
May 2, 2024

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Apr 17, 2024

[why]
Some internals of the font-patcher changed since 2.3.3, that we use directly.

[note]
If we run a new release we get the current CascadiaCode with Nerd Fonts v3.x.x codepoints.
The codepoints did change for some icons.
On the other hand Nerd Fonts v3.0.0 has been already a while, so most people and other software should have changed the relevant codepoints in the meantime. To get all the new features of Nerd Fonts we probably want to follow that codepoint change.

See also

@Finii
Copy link
Collaborator Author

Finii commented Apr 17, 2024

Do we want to update Delugia from Nerd Fonts 2.3.3 to Nerd Fonts 3.2.1?

If yes we need this and then can just trigger a new sub-release.

@Finii Finii requested a review from adam7 April 17, 2024 10:09
[why]
Some internals of the font-patcher changed since 2.3.3, that we use
directly.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator Author

Finii commented May 2, 2024

Rebase on master, force push

@Finii Finii force-pushed the feature/NF3.2.1 branch 2 times, most recently from e21b9bc to 237f782 Compare May 2, 2024 10:28
Finii added 2 commits May 2, 2024 12:29
[why]
Some actions still run with Node16.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
The actual message changes with the newest font-patcher and furthermore
the message is suppressed unless specifically run in debug mode.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator Author

Finii commented May 2, 2024

I have forgotten how the auto-release-thing works.
Merging this now and lets see 😀
I believe it should tag the repo and create a new release... 🤔

@Finii Finii merged commit f843ba4 into master May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants