Make the session key configurable. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new setting TZ_SESSION_KEY which defaults to the current detected_tz. This will allow integration to other django projects that make assumptions about timezones and sessions.
mblayman
approved these changes
Apr 12, 2024
| .. code-block:: python | ||
|
|
||
| # Session key to use, defaults to "detected_tz" | ||
| TZ_SESSOIN_KEY = "my-session-key" |
There was a problem hiding this comment.
Suggested change
| TZ_SESSOIN_KEY = "my-session-key" | |
| TZ_SESSION_KEY = "my-session-key" |
| @@ -6,3 +6,7 @@ | |||
| # Defaults to top Internet using countries. | |||
|
|
|||
| TZ_DETECT_COUNTRIES = getattr(settings, "TZ_DETECT_COUNTRIES", ("CN", "US", "IN", "JP", "BR", "RU", "DE", "FR", "GB")) | |||
|
|
|||
|
|
|||
| # Session yey to use to store the detected timezone | |||
There was a problem hiding this comment.
Suggested change
| # Session yey to use to store the detected timezone | |
| # Session key to use to store the detected timezone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new setting TZ_SESSION_KEY which defaults to the current detected_tz. This will allow integration to other django projects that make assumptions about timezones and sessions.