Add end_month and end_day feature to setup_fiscal_calendar #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicmendoza
reviewed
Sep 14, 2021
fiscalyear.py
Outdated
| """Modify the fiscal calendar. | ||
|
|
||
| If either of ``start_month`` or ``start_day`` are present, ``end_month`` | ||
| and ``end_day`` are ignored. |
There was a problem hiding this comment.
This might be surprising behavior. I think it would be preferable to throw an error when invalid combinations of arguments are supplied
|
Added logic to check for invalid combination of supplied arguments with 6955029 Implemented logic in new function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from discussion on #20 , adding support for
end_monthandend_dayfeature tosetup_fiscal_calendar. My coding skillz are far from brilliant, so welcome any/all suggestions for improvement.