Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shard partitioner #2792

Merged
merged 19 commits into from
Feb 27, 2024
Merged

Add shard partitioner #2792

merged 19 commits into from
Feb 27, 2024

Conversation

adam-narozniak
Copy link
Contributor

@adam-narozniak adam-narozniak commented Jan 15, 2024

Proposal

The algorithm based on the description in Communication-Efficient Learning of Deep Networks from Decentralized Data https://arxiv.org/abs/1602.05629.

@adam-narozniak adam-narozniak self-assigned this Jan 16, 2024
@adam-narozniak adam-narozniak marked this pull request as ready for review January 16, 2024 16:46
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions to the text

datasets/flwr_datasets/partitioner/shard_partitioner.py Outdated Show resolved Hide resolved
datasets/flwr_datasets/partitioner/shard_partitioner.py Outdated Show resolved Hide resolved
datasets/flwr_datasets/partitioner/shard_partitioner.py Outdated Show resolved Hide resolved
datasets/flwr_datasets/partitioner/shard_partitioner.py Outdated Show resolved Hide resolved
datasets/flwr_datasets/partitioner/shard_partitioner.py Outdated Show resolved Hide resolved
datasets/flwr_datasets/partitioner/shard_partitioner.py Outdated Show resolved Hide resolved
datasets/flwr_datasets/partitioner/shard_partitioner.py Outdated Show resolved Hide resolved
datasets/flwr_datasets/partitioner/shard_partitioner.py Outdated Show resolved Hide resolved
datasets/flwr_datasets/partitioner/shard_partitioner.py Outdated Show resolved Hide resolved
adam-narozniak and others added 4 commits January 30, 2024 14:07
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
The fix works when the shard_size is given along the
num_shards_per_partition
@danieljanes danieljanes enabled auto-merge (squash) February 27, 2024 09:19
@danieljanes danieljanes merged commit 65f77a9 into main Feb 27, 2024
34 checks passed
@danieljanes danieljanes deleted the fds-add-shard-partitioner branch February 27, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants