feat(datasets) Add a check for same object partitioners #4335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p/flower into fds-improve-multipartitioners-checks
adam-narozniak
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
jafermarq
reviewed
Dec 3, 2024
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
approved these changes
Dec 4, 2024
flydump
pushed a commit
to flydump/flower
that referenced
this pull request
Dec 8, 2024
Co-authored-by: jafermarq <javier@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
partitionersspecification as dict of split to the partitioner object should not have the same objects (value of the dict) assigned to different keys (even if the same type of partitioning happens for different splits).Proposal
This PR adds a check to ensure this correctness (without it, the code "fails" silently, the non-first used split will not be partitioned but the partitions of the first divided split will be returned).
Examples
This would fail silently
With this PR, it would raise an error.