-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(datasets) Add dataset contribution guide #4601
Merged
Merged
+63
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-narozniak
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
November 28, 2024 12:42
jafermarq
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @adam-narozniak , it looks pretty good. I like the inclusion of a mini example at the bottom. Some comments below to move some text around a bit.
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
reviewed
Nov 29, 2024
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
approved these changes
Nov 29, 2024
flydump
pushed a commit
to flydump/flower
that referenced
this pull request
Dec 8, 2024
Co-authored-by: jafermarq <javier@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain how to add a dataset and make it available in
flwr-datasets
ecosystem.