Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Transformers to v4.33.3 #586

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Conversation

calpt
Copy link
Member

@calpt calpt commented Sep 9, 2023

Upgrade notes:

- Add argument to `_resize_token_embeddings()`
- Add seq. classification head to T5
- Fix test config of Llama
Move used heads retrieval to new method.
@calpt calpt marked this pull request as ready for review September 17, 2023 09:22
@calpt calpt changed the title Upgrade Transformers to v4.33.1 Upgrade Transformers to v4.33.2 Sep 17, 2023
@TimoImhof TimoImhof self-assigned this Sep 26, 2023
Copy link
Contributor

@TimoImhof TimoImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks for working on this!

One question: with which transformer version does the pipeline conduct the tests?

if isinstance(model, T5AdapterModel) or isinstance(model, BertGenerationAdapterModel):
if isinstance(model, BertGenerationAdapterModel):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general question: Why do we differentiate between the models in these tests? And why can we exclude T5 now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model handled differently here don't support sequence classification heads, which are used for these test cases by default. T5 now supports sequence classification heads.

@calpt calpt changed the title Upgrade Transformers to v4.33.2 Upgrade Transformers to v4.33.3 Oct 5, 2023
@calpt calpt merged commit 5652c0b into adapter-hub:adapters Oct 5, 2023
5 checks passed
@calpt calpt deleted the sync/v4.33.1 branch October 5, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants