-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Whisper #693
Merged
Merged
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
ad9fe2b
save current progress:
TimoImhof 7ebb5e8
Merge branch 'adapter-hub:main' into dev/whisper
TimoImhof 1e10398
Implement WhisperAdapterModel:
TimoImhof c775d43
add logger for Attention module
TimoImhof 23f1c68
Add Whisper model to documentation
TimoImhof f4b3df8
Add WhisperDecoderWrapperAdaptersMixin:
TimoImhof dc40973
Add tests
TimoImhof a0a89ed
save progress
TimoImhof f36133c
save progress
TimoImhof f011bb3
overwrite get_input_samples method to fix tests requiring simple inpu…
TimoImhof 08464c2
add support for speech samples with "input_features" as tensor name
TimoImhof 32a6434
fix wrong input argument
TimoImhof d13b6d3
upload dev files for experiments
TimoImhof f5e4269
upload dev files for experiments
TimoImhof 70f7651
update SpeechTestBase
TimoImhof e38cd9e
Add copy info and add flash attention
TimoImhof 8587f0f
Changes:
TimoImhof 909fecb
Changes:
TimoImhof fcaa21e
Delete dev dir
TimoImhof 9bd7065
add TODOS
TimoImhof 25171bb
make method more general
TimoImhof 6405be4
add methods necessary for head usage
TimoImhof c52f0c3
Add TODO
TimoImhof cc00ed6
remove redundant code
TimoImhof 24f72d6
add comment & enable all tests
TimoImhof 182f5a5
Add special check for vision models
TimoImhof e44a482
make style
TimoImhof ca41958
add speech_classification head
TimoImhof 158165b
Adapting tests:
TimoImhof 0eadf6d
update dataset
TimoImhof d4117b7
residual updates:
TimoImhof 091d947
Include adapters.init() support for:
TimoImhof 5e8bf99
Adapt Testbase
TimoImhof c483068
Fixes:
TimoImhof 480b4b6
Changes:
TimoImhof 38bbb06
Add custom classification head
TimoImhof 4ddc919
Fix embedding text:
TimoImhof 4d6e9cc
Fix generation
TimoImhof e54f1c4
Fix composition and invertible adapters
TimoImhof 1c6aebd
Merge branch 'main' into dev/whisper
TimoImhof 980a3f4
Revert test changes:
TimoImhof 11daca4
manually handle failing style checks:
TimoImhof 63ca22a
- remove audio classification from WhisperAdapterModel head classes
TimoImhof 4069c94
Remove redundant code:
TimoImhof 6beba77
fix typo
TimoImhof faf54b6
fix conditional case and remove redundant code line
TimoImhof fcdc409
fix prompt tuning test
lenglaender e513263
Add ConversionTests and AudioClassificationMixin
TimoImhof acd5332
polish docs
TimoImhof c8427b0
polish docs
TimoImhof 7e3e108
Fix import
TimoImhof 69e3c99
Remove redundant files
TimoImhof af2ddc2
Update src/adapters/model_mixin.py
TimoImhof 57b411a
Apply suggestions
TimoImhof 61f3742
Merge remote-tracking branch 'origin/dev/whisper' into dev/whisper
TimoImhof f01b51e
Merge branch 'main' into dev/whisper
TimoImhof 1f8573f
Fix failing test and refactor speech model case handling
TimoImhof 8d04de1
Fix failing test
TimoImhof 5b41382
Fix overwriting arguments
TimoImhof 327381e
make style
TimoImhof a30bb6c
Address remaining comments, fix conversion test, correct documentatio…
TimoImhof ad47696
Revert forward function signature modification
TimoImhof 6111b07
Merge branch 'adapter-hub:main' into dev/whisper
TimoImhof 53b9cd9
make style
TimoImhof 7526514
Remove redundant head - not supported by any model
TimoImhof 0588db6
Add Future TODO for seq2seqtrainer
TimoImhof 1751a25
Merge branch 'refs/heads/main' into dev/whisper
TimoImhof 08911d8
Incorporate pyreft tests
TimoImhof 88bd867
Add check for changing hidden_states size
TimoImhof 3de2581
Adapt checking logic
TimoImhof 89377f8
Merge branch 'refs/heads/main' into dev/whisper
TimoImhof 5f4f20c
Fix attention classes and generation
TimoImhof File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch! should we check the full shape here since bsz and ddim might also change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, then we have all potential cases covered 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However I now realized that my checking logic was not correct; the indixing matrices and hidden_states do never have the same value at dim1:
We need to check for the actual values of suff_idx to see if the indexing values are out of bounds. I adapted the logic and added checks for the residual dimensions as well.
When the tests passed locally I will push the changes for review