Issue 1319,5450,1285 - FilterEngine and Updater JS api separation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved Updater class to dedicated header and source files. Created apiUpdater.js with a separate API for Updater component. Updated unit tests. Signed-off-by: Krystian Zlomek k.zlomek@eyeo.com
kzlomek
force-pushed
the
refactoring_task_rebased
branch
from
0a3f088 to
7a6c647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Updater class to dedicated header and source files.
Created apiUpdater.js with a separate API for Updater component.
Updated unit tests.
Signed-off-by: Krystian Zlomek k.zlomek@eyeo.com