Update PickerItem.tsx to allow values of type number
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow values for the picker to be strings or numbers, so that I don't have to do custom transformation logic on the values. This is particularly useful for a picker for numeric values like height, where I really want to store it as a number and not a string.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
panzacoder
changed the title
number
…be better to allow the values to be generics if they aren't strings? Would be interested in thoughts
panzacoder
commented
May 29, 2024
| @@ -23,7 +23,7 @@ export default function ModalPicker() { | |||
|
|
|||
| const { year, month } = newValue | |||
| const newDayArray = getDayArray(Number(year), Number(month)) | |||
| const newDay = newDayArray.includes(newValue.day) ? newValue.day : newDayArray[newDayArray.length - 1] | |||
| const newDay = newDayArray.includes(newValue.day as string) ? newValue.day : newDayArray[newDayArray.length - 1] | |||
There was a problem hiding this comment.
Had to add this coercion to the test. This could possibly be avoided through type inference or generics, instead of just a union as I added: string | number.
Interested in your thoughts @adcentury
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow values for the picker to be strings or numbers, so that I don't have to do custom transformation logic on the values.
This is particularly useful for a picker for numeric values like height, where I really want to store it as a number and not a string.