Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build executable jar file. #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build executable jar file. #31

wants to merge 1 commit into from

Conversation

mostafabarmshory
Copy link

Some configuration is added into the POM.xml to build an executable JAR file.

@tzifudzi
Copy link

tzifudzi commented Sep 5, 2019

Not a reviewer but pull request seems fine. Can this be accepted?

tiagoms1
tiagoms1 requested changes Sep 3, 2020
View reviewed changes
Copy link
Collaborator

@tiagoms1 tiagoms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gotten the most part of this upgrade and others, please take a look and check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoms1 tiagoms1 tiagoms1 requested changes

@tzifudzi tzifudzi tzifudzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mostafabarmshory @tzifudzi @tiagoms1