refactor: Major refactoring of the ubw importer #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update was made because the newer API is more usable and allows the use of streams. So the project benefits in some places by simplifying the logic.
By introducing helper classes, several places in the program code can be simplified. For example, the indices can be extracted and held in an object. Furthermore, an enum describes all possible fields that are relevant. This allows fields to be easily removed or added in the future.
The logic has been simplified in some places and repeating program code has been outsourced to separate methods. In addition, some places were implemented using streams, which simplifies the code and improves performance. Additionally there were some technical changes to used variables.
These exceptions couldn't occur in these places anymore.
FrederikSchlemmer
force-pushed
the
importerRefactoring
branch
from
183cfe5
to
cac939a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several places in the code which could be optimized. Furthermore, the indexes are now found and assigned dynamically, so that hardcoded indexes are no longer necessary.
Additionally we switched to streams in several places to simplify the code and improve the performance.