person-details: Adds defaultDailyRate and minor design changes #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defaultDailyRate is added to the highlights displayed on the person details page. Additionally the formatting of the date has been changed.
tinne
reviewed
Feb 3, 2021
There was a problem hiding this comment.
Fast forward merging drives me mad. There is only one commit to this PR, and part of it is already part of the release branch. If one the missing space was added later on, all well. However, do I really need to check with all eight files in the change set to find out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the style of the person details page. The person highlights now include the defaultDailyRate and the year of the dates are displayed with four digits.
This pull request replaced #446.
Closes #441