Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved code style #30

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Tautve
Copy link

@Tautve Tautve commented Oct 2, 2022

improved code style by importing some use statements, substr replacing with strpos

@adhocore
Copy link
Owner

adhocore commented Oct 3, 2022

helo, thanks for this PR. im gonna accept this PR if the build passes and you kindly can format the commit message to angular format (as are other commits before) : https://github.styleci.io/analyses/prOrAR

however since it is not feature or fix or significant refactor - i don't know if it should be #hacktoberfest-accepted though.

edit: since you are a first time contributor, as a courtesy i will mark it as #hacktoberfest-accepted :)
(pls address the comment above though)

src/JWT.php Outdated Show resolved Hide resolved
@adhocore
Copy link
Owner

adhocore commented Oct 4, 2022

seems you didnt check https://github.styleci.io/analyses/prOrAR
also might need to rebase commit msg for this one a7037d6


da7158a should be:

refactor: changed the order of use statements in JWT.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants