fix(css): post header margin on mobile #1553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Guillot
force-pushed
the
patch-2
branch
2 times, most recently
from
b6ffa75 to
12a53f1
Compare
|
.post-header was not using the `--gap` variable, so the overriding of this variable on mobile was not applied.
David-Guillot
force-pushed
the
patch-2
branch
from
12a53f1 to
0252f45
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
On mobile, the spacing between the page header and the post title feels too big. I guessed this is caused by the use of hard-coded
24pxonmargin-topinstead of the--gapvariable, whose value is24pxby default but get down to14pxon smaller screens and mobile.See the difference on the theme Install page:
Was the change discussed in an issue or in the Discussions before?
Clearly not 😬
PR Checklist