Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SHACL #356

Closed
wants to merge 4 commits into from
Closed

Fix SHACL #356

wants to merge 4 commits into from

Conversation

mhrimaz
Copy link
Contributor

@mhrimaz mhrimaz commented Feb 18, 2024

Fixes #330 and few other issues.

fix invalid regexes.
change multilang texts in iec data spec to AbstractLangString/text.
add rdf prefix to sparql constraints
@mristin
Copy link
Collaborator

mristin commented Feb 18, 2024

@mhrimaz thanks for the fix -- but since the schemas are automatically generated by aas-core-codegen, your changes will be silently overwritten.

Can you please first sync up with @sebbader, and once you confirmed the changes propagate them to:
https://github.com/aas-core-works/aas-core-codegen/blob/main/aas_core_codegen/rdf_shacl/shacl.py

@mhrimaz
Copy link
Contributor Author

mhrimaz commented Feb 27, 2024

Either SHACL or official example should be adapted regarding the AbstractLangString in IEC related attributes.
image

And this is the issue with regex format:
image

@BirgitBoss BirgitBoss added the Schemas generated schemata for xml, JSON and rdf or XMI label May 5, 2024
@mhrimaz
Copy link
Contributor Author

mhrimaz commented Sep 18, 2024

Will be resolved in aas-core-works/aas-core-codegen#526

@mhrimaz mhrimaz closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Schemas generated schemata for xml, JSON and rdf or XMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] missing rdf prefix in SHACL's SPARQL queries
3 participants