fix(breaking-change): update for nodes 18 and 20 (#59)

adobe · Dec 5, 2023 · 87a2e7f · 87a2e7f
1 parent 79c1878
commit 87a2e7f
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml
@@ -10,7 +10,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node: [16]
+        node-version: [18]
         os: [ubuntu-latest]
 
     steps:
@@ -29,6 +29,6 @@ jobs:
       env:
         SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
         SLACK_TITLE: 'Node version'
-        SLACK_MESSAGE: ${{ matrix.node }}
+        SLACK_MESSAGE: ${{ matrix.node-version }}
         SLACK_COLOR: ${{ job.status == 'success' && 'good' || job.status == 'cancelled' && '#808080' || 'danger' }}
 
diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml
@@ -17,7 +17,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [18.x, 20.x]
         os: [ubuntu-latest, windows-latest]
 
     steps:

diff --git a/.github/workflows/on-push-publish-to-npm.yml b/.github/workflows/on-push-publish-to-npm.yml
@@ -12,7 +12,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
         with:
-          node-version: 16
+          node-version: 18
       - run: npm install
       - run: npm test
       - uses: JS-DevTools/npm-publish@v1

diff --git a/.github/workflows/prerelease.yml b/.github/workflows/prerelease.yml
@@ -26,7 +26,7 @@ jobs:
           git config user.email github-actions@github.com
       - uses: actions/setup-node@v1
         with:
-          node-version: 16
+          node-version: 18
       - run: |
           npm install
           npm test

diff --git a/.github/workflows/version-bump-publish.yml b/.github/workflows/version-bump-publish.yml
@@ -21,7 +21,7 @@ jobs:
           git config user.email github-actions@github.com
       - uses: actions/setup-node@v1
         with:
-          node-version: 16
+          node-version: 18
       - run: |
           npm install
           npm test

diff --git a/package.json b/package.json
@@ -60,6 +60,6 @@
     "unit-tests": "jest --config test/jest.config.js --runInBand"
   },
   "engines": {
-    "node": "^14.16 || ^16.13 || >=18"
+    "node": ">=18"
   }
 }
diff --git a/src/ProxyFetch.js b/src/ProxyFetch.js
@@ -42,6 +42,8 @@ function proxyAgent (resourceUrl, authOptions) {
     logger.warn(`proxyAgent - rejectUnauthorized is set to ${rejectUnauthorized}`)
   }
 
+  proxyOpts.ALPNProtocols = ['http/1.1']
+
   if (resourceUrl.startsWith('https')) {
     return new HttpsProxyAgent(proxyOpts)
   } else {