Issue #8191 : New instance with shift+click

[deandersson]

Changed key for on startup being able to specify index.html from shift to Right shift. This makes it possible to start a new instance with left shift+click on taskbar with default index.html while still being able to start brackets with right shift to specify index.html. Suggestion for using Alt does not work since holding Alt will open 'Properties' window (on win 8.1).

P.S first contribution on github.. Sorry if im not following protocol here... :)

[abose]

@deandersson Thanks for contributing to brackets. There are no official protocols for logging issues here, feel free to raise them if you find in brackets.
The shortcuts have been in brackets for a couple of years now and its one of the most widely used shortcuts among brackets Devs. Changing the shift key could be a bit hard to go through- but maybe the left/right shift distinction could help.
Another thing is that brackets is not fully good with multiple windows, Some of the brackets functionality will breakdown in multiple window mode. So I recommend using single window mode.

[deandersson]

Ah i see. In that case it might be annoying to change it!
I noticed that Brackets is not really happy about going into multiple windows. Would it be good to enforce it some way and only allow it through Debug > New window so "regular" users does not think it is a bug?
I also read somewhere that Brackets goal is to be run in browsers so then maybe its a non-issue.

[abose]

@nethip @prksingh @marcelgerber @ryanstewart
Do we want to take this change?

[nethip]

@deandersson Welcome to Brackets Community! And thanks for your efforts in contributing to Brackets.

@abose We are now restricting only one instance of Brackets to be running via this PR. This is a windows only change though. This will make it to Brackets 1.4 release.

@deandersson It would be of great help to us if you can pull the latest master and check if that is making sure we are running only one instance of Brackets. Thanks!

[abose]

OH wait! I merged that single instance commit. 😅 forgot.
Left shift or right shift ? I would prefer left shift for brackets but then, left shift is the default key i use for windows multi window too. Maybe will ask in slack.

[nethip]

@abose Now that we are restricting the number of running Brackets instances to one, do you think we still want to change the left shift to right shift?

[abose]

So you are saying that brackets cannot have multiple windows enabled from the next version.
This would mean that we do not need to take this change as we will not have multiple windows anyway.

[nethip]

Yes.

[abose]

Then we could verify this on the updated shell and close. We need not merge the PR in the case.

[deandersson]

Bah I see now my mistake here.. I tested the shift+click on taskbar in the latest stable release and not in the latest source.. Didnt even cross my mind that it might have been disabled.
When i made my change in the source I only tested that the shiftkey was working as intended when starting from the executable and not on an open instance of Brackets.. 😊

@nethip in the latest master it works as intended, you cant open a new instance by shift+clicking on the taskbar. So this "fix" is kind of pointless haha.

Should I Close my PR or does someone else do it when it has been reviewed?

[nethip]

@deandersson No worries! Thanks for verifying this behavior on master. and also for this PR.

There are some other PRs/work items where we could use some help. Would you mind taking a look at this PR:#507. This is a very good change but right now it is a bit stalled because of some unit testing bugs(please read through the comments). It would be great if you can take a look at it and help us fix those unit testings defects. Let me know if you need more info on this.

For now, I am closing this PR.

[deandersson]

@nethip Of course! I will see what I can do! 😄

[abose]

@deandersson
If you are interested in contributing to new features in brackets, take a look at the trello board
Starter Issues are smaller issues that you can look at to start with the code base.
Also you could join brackets google groups discussions.