Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Merging changes to release branch for 1.14.1 patch release #671

Open
wants to merge 3 commits into
base: release
Choose a base branch
from
Open

Merging changes to release branch for 1.14.1 patch release #671

wants to merge 3 commits into from

Commits on Nov 18, 2019

  1. Disabled remote-debugging by default and appshell.app.getRemoteDebugg… 

    …ingPort() needs a callback argument to work (adobe#668)

* Disabled remote-debugging by default and appshell.app.getRemoteDebuggingPort() needs a callback argument to work

* Addressing review comments

* Addressing review comments

* Updating error meesage for port validation

* Addressing review comments from vickramdhawal, also it is not possible to use g_handler to hold remote-debugging-port as g_handler does not get initialized while we are parsing command line

* More error message correction
    @g-217
    g-217 committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    9a566b8 View commit details
    Browse the repository at this point in the history

  2. Improved console error messages (adobe#669)

    @g-217
    g-217 committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    340be0e View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2019

  1. Merge pull request adobe#673 from jha-g/jha-g/moving-commandline-erro… 

    …r-to-infobar2

moving command line error to infobar and fixing windows port range issues
    @narayani28 @g-217
    narayani28 authored and g-217 committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    c662e97 View commit details
    Browse the repository at this point in the history