This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Incorporating changes for the brackets.io redesign #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narayani28
reviewed
Jan 24, 2018
| <link rel="stylesheet" href="/css/brackets.io.css"> | ||
|
|
||
| <!-- Linked Favicon --> | ||
| <link rel="shortcut icon" href="favicon.ico" /> |
There was a problem hiding this comment.
Has the icon and the fonts below at lines 39 and 40 legally validated to be used in the site? Check with PgM once on the legal.
There was a problem hiding this comment.
The favicon used is the existing one. I have not changed that.
As for the webfonts. They are served though Google fonts API, and are free to use in a commercial and Non-commercial project. https://developers.google.com/fonts/
All other icons used have been properly attributed for, in consultation with Legal
narayani28
reviewed
Jan 24, 2018
404.html
Outdated
| <a href="contribute.html" class="contribute" data-i18n="nav.contribute">Contribute</a> | ||
| <a href="docs/current/modules/brackets.html" data-i18n="nav.apidocs">API Docs</a> | ||
| <a href="https://registry.brackets.io/" data-i18n="">Extensions</a> |
There was a problem hiding this comment.
empty attribute for data-i18n?
narayani28
reviewed
Jan 24, 2018
| - Get the development dependencies for the submodule | ||
|
|
||
| ```bash | ||
| npm install |
There was a problem hiding this comment.
Mention the node version with which you have tested .
narayani28
reviewed
Jan 24, 2018
img/LICENSE.txt
Outdated
| to represent the company, product, or service to which they refer.** | ||
|
|
||
| ################################################################################# | ||
| Modified by Adobe Systems Incorporated 2017. |
narayani28
reviewed
Jan 24, 2018
narayani28
approved these changes
Jan 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the io side changes that were done as part of the brackets website redesign.
This covers:
SIte can be visually reviewed at https://shubhsnov.github.io/brackets.io
ping @nethip and @swmitra for review.