use universal runtime for embeds #1056
Conversation
|
This PR will trigger a patch release when merged. |
src/schemas/secrets.schema.json
Outdated
| }, | ||
| "DATA_EMBED_SERVICE": { | ||
| "type": "string", | ||
| "description": "URL of a DataEmbed Service that takes the appended URL and returns an iterable JSON representation.", | ||
| "default": "https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v1" | ||
| "default": "https://helix-pages.anywhere.run/helix-services/data-embed@v2" |
There was a problem hiding this comment.
this doesn't really work for non-universal actions, since the version lock only works for runtime actions.
for universal, this is hardcoded:
helix-pipeline/src/html/fetch-data.js
Lines 29 to 33 in 3827070
so I would revert the data-embed change.
also see #1058
There was a problem hiding this comment.
I added a commit to revert the data-embed change
Codecov Report
@@ Coverage Diff @@
## main #1056 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 60
Lines 1602 1602
=========================================
Hits 1602 1602 Continue to review full report at Codecov.
|
| }, | ||
| "DATA_EMBED_SERVICE": { | ||
| "type": "string", | ||
| "description": "URL of a DataEmbed Service that takes the appended URL and returns an iterable JSON representation.", | ||
| "default": "https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v1" | ||
| "default": "https://adobeioruntime.net/api/v1/web/helix/helix-services/data-embed@v2" |
|
Made obsolete by #1057 |
trieloff
changed the title
|
https://circleci.com/workflow-run/f0d0b24f-e666-4b27-873f-e684f7c6ccbe The smoke test failures seem unrelated. |
adobe/helix-pipeline#1056 switches the embed service URL to universal runtime. This means that some of the recordings for the integration tests need to be re-downloaded, as the URL has changed. As helix-embed has evolved in the meantime, this also means that the test output has changed a bit. There is a good chance that we will end up in a smoke test deadlock, as this PR won't pass the tests until adobe/helix-pipeline#1056 has been merged and vice versa.
|
🎉 This PR is included in version 13.9.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
#1745) adobe/helix-pipeline#1056 switches the embed service URL to universal runtime. This means that some of the recordings for the integration tests need to be re-downloaded, as the URL has changed. As helix-embed has evolved in the meantime, this also means that the test output has changed a bit. There is a good chance that we will end up in a smoke test deadlock, as this PR won't pass the tests until adobe/helix-pipeline#1056 has been merged and vice versa.
No description provided.