chore: nocontent test

adobe · Dec 14, 2023 · 257bb2e · 257bb2e
1 parent 20e98fa
commit 257bb2e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/spacecat-shared-utils/src/http-utils.js b/packages/spacecat-shared-utils/src/http-utils.js
@@ -32,8 +32,8 @@ export function ok(body) {
   return createResponse(body, 200);
 }
 
-export function noContent(body) {
-  return createResponse(body, 204);
+export function noContent(headers) {
+  return createResponse('', 204, headers);
 }
 
 export function badRequest(message) {

diff --git a/packages/spacecat-shared-utils/test/http-utils.test.js b/packages/spacecat-shared-utils/test/http-utils.test.js
@@ -12,7 +12,7 @@
 /* eslint-env mocha */
 import { expect } from 'chai';
 import {
-  ok, badRequest, notFound, internalServerError,
+  ok, badRequest, notFound, internalServerError, noContent,
 } from '../src/http-utils.js';
 
 describe('http-utils', () => {
@@ -25,6 +25,16 @@ describe('http-utils', () => {
     expect(respJson).to.eql(body);
   });
 
+  it('ok should return a 204 response with JSON body', async () => {
+    const headers = { key: 'value' };
+    const response = noContent(headers);
+    expect(response.status).to.equal(204);
+    expect(response.headers.get('content-type')).to.equal('application/json; charset=utf-8');
+    expect(response.headers.get('key')).to.equal('value');
+    const respJson = await response.json();
+    expect(respJson).to.eql('');
+  });
+
   it('badRequest should return a 400 response with JSON body', async () => {
     const response = badRequest('Bad Request');
     expect(response.status).to.equal(400);