Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependent remove errors, more tests #532

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

solaris007
Copy link
Member

@solaris007 solaris007 commented Jan 10, 2025

  • make sure parent record is not removed if any of the child records fails to remove
  • add more IT tests

@solaris007 solaris007 added the bug Something isn't working label Jan 10, 2025
@solaris007 solaris007 self-assigned this Jan 10, 2025
@solaris007 solaris007 merged commit cdec563 into main Jan 10, 2025
7 checks passed
@solaris007 solaris007 deleted the fix-remove-dependents-tests branch January 10, 2025 08:25
solaris007 pushed a commit that referenced this pull request Jan 10, 2025
# [@adobe/spacecat-shared-data-access-v1.61.19](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v1.61.18...@adobe/spacecat-shared-data-access-v1.61.19) (2025-01-10)

### Bug Fixes

* dependent remove errors, more tests ([#532](#532)) ([cdec563](cdec563))
@solaris007
Copy link
Member Author

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v1.61.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants