include luxon date time options to date #177
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Including the luxon date time options increases the developer's possibilities in other scenarios, here are some of them:
It is required to receive a date in ISO format and the validation result must return the time zone specified by the developer (ex: UTC):
{ published_at: schema.date({ format: 'iso', opts: { zone: 'UTC' } }) }
input: 2023-09-28T17:05:05.903-04:00
output: 2023-09-28T21:05:05.903Z
It is required to receive a date in ISO format and the validation result to return a DateTime object with the same input time zone, not necessarily the default time zone as it currently works, (assume default time zone in UTC):
{ published_at: schema.date({ format: 'iso', opts: { setZone: true } }) }
input: 2023-09-28T17:05:05.903-04:00
expected output equals to input: 2023-09-28T17:05:05.903-04:00
current output: 2023-09-28T21:05:05.903Z
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...