Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to AdapterFetch #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patocallaghan
Copy link
Collaborator

Part of #444

Fixes deprecate-fetch-ember-data-support deprecations

@patocallaghan
Copy link
Collaborator Author

All DRFSerializer (Django Rest Adapter) tests are currently failing 🔴

@Techn1x
Copy link
Contributor

Techn1x commented Dec 3, 2022

Seems the specific tests that are failing are DRF tests that are checking the error payload - any test that has the line reason.errors[0] has an issue (errors is not defined), eg

assert.equal(reason.errors[0].status, '404');

It's failing to generate the correct error payloads, instead it's throwing an actual error in the django adapter - traced it back to this line

https://github.com/dustinfarris/ember-django-adapter/blob/32035bb13d57cb8896bdf1eda560d027e76b6760/addon/adapters/drf.js#LL108C4-L108C60

with fetch adapter: payload = "Not Found"
without fetch adapter: payload = null

It seems the FetchAdapter parses the fetch response for errors slightly different than the RestAdapter that the DjangoAdapter uses

From there I get a bit out of my depth, but I hope that helps you out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants