Update TAP information for jck tests #440
Conversation
sophia-guo
force-pushed
the
jck
branch
2 times, most recently
from
ebfea3f
to
e9943d5
Compare
|
run tkg-test |
|
@renfeiw TKG test build started, workflow Run ID: 4703823692 |
|
@renfeiw Build(s) successful, workflow Run ID: 4703823692 |
|
run tkg-test |
|
@renfeiw TKG test build started, workflow Run ID: 4736333197 |
|
@renfeiw Build(s) successful, workflow Run ID: 4736333197 |
| if ($buildList =~ /openjdk/) { | ||
| if ($diagnostic eq 'all') { | ||
| $tapString .= $output; | ||
| } |
There was a problem hiding this comment.
Looks it is missing one case: if diagnostic eq 'failure' and buildList is not openjdk or jck, we still need to append output to tapString.
| $tapString .= $output; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we need to update
elsif ($diagnostic eq 'failure') {
to
else {
And remove
if ($diagnostic eq 'all') {
$tapString .= $output;
}
Because if $diagnostic eq 'all' and buildlist is openjdk or jck, output will be appended twice.
|
@sophia-guo does this still need some rework or should we land it? |
|
@sophia-guo is this PR ready or still need some rework? |
Update to add all test output information if diagnostic is 'all' Filter and summarize failure tests in a similar way to openjdk tests Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
|
Close in favour of #504 |
Close #439
Signed-off-by: Sophia Guo sophia.gwf@gmail.com