Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getJtreg into getDependencies #473

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Move getJtreg into getDependencies #473

merged 1 commit into from
Nov 23, 2023

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Nov 15, 2023

-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

@annaibm
Copy link
Contributor Author

annaibm commented Nov 15, 2023

Grinder outputs:
openjdk: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36142/
Crypto test: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36150/
ssl-test:https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36151

llxia
llxia requested changes Nov 17, 2023
View reviewed changes
scripts/getDependencies.xml Outdated Show resolved Hide resolved
scripts/getDependencies.xml Outdated Show resolved Hide resolved
scripts/getDependencies.xml Outdated Show resolved Hide resolved
scripts/getDependencies.xml Outdated Show resolved Hide resolved
@annaibm
Copy link
Contributor Author

annaibm commented Nov 17, 2023

Made requested changes. Kindly review.
Grinder outputs:
openjdk: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36177/ (36178)
Crypto test: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36180/
ssl-test:https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36181

@annaibm annaibm requested a review from llxia November 21, 2023 20:30
llxia
llxia reviewed Nov 21, 2023
View reviewed changes
scripts/getDependencies.xml Outdated Show resolved Hide resolved
@annaibm annaibm force-pushed the move_getJtreg_4848 branch 3 times, most recently from a9772a1 to 842f700 Compare November 22, 2023 14:21
@annaibm annaibm requested a review from llxia November 22, 2023 16:51
@annaibm annaibm marked this pull request as ready for review November 22, 2023 20:43
@annaibm
Copy link
Contributor Author

annaibm commented Nov 22, 2023

Grinder outputs:
openjdk: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36330/
openjdk with hotspot: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36373/
Crypto test: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36331/
ssl-test:https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/36332/

llxia
llxia reviewed Nov 22, 2023
View reviewed changes
scripts/getDependencies.xml Outdated Show resolved Hide resolved
@annaibm
Move getJtreg into getDependencies
32f84eb 
-Moved the getJtreg version download logic into TKG/scripts/getDependencies.xml

resolves : adoptium/aqa-tests#4848

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
@annaibm annaibm requested a review from llxia November 22, 2023 21:01
@llxia llxia mentioned this pull request Nov 22, 2023
Merged
llxia
llxia approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from smlambert November 22, 2023 21:18
@karianna karianna merged commit 21c9cfc into adoptium:master Nov 23, 2023
3 checks passed
@annaibm annaibm deleted the move_getJtreg_4848 branch January 17, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@llxia llxia llxia approved these changes

@smlambert smlambert Awaiting requested review from smlambert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move getJtreg ant target to a shared location
3 participants
@annaibm @karianna @llxia