Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export LIB_DIR #481

Merged
merged 1 commit into from
Dec 13, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ endif
ifeq ($(CYGWIN),1)
LIB_DIR:=$(shell cygpath -w $(LIB_DIR))
endif
LIB_DIR:=$(subst \,/,$(LIB_DIR))

export LIB_DIR:=$(subst \,/,$(LIB_DIR))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not recommended to change values and export in one cmd. Please separate the code into two lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just trying to keep the same style

TKG/makefile

Line 22 in 4c1094f

export TEST_JDK_HOME:=$(subst \,/,$(TEST_JDK_HOME))


_TESTTARGET = $(firstword $(MAKECMDGOALS))
TESTTARGET = $(patsubst _%,%,$(_TESTTARGET))
Expand Down