Correct CYGWIN LIB_DIR #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
|
The issue was reported by slack https://adoptium.slack.com/archives/C5219G28G/p1704231165068949. When running locally (not explicitly set LIB_DIR) on window cygwin , the compile step failed due to missing json-simple.jar. The PR should also fix the PR tests with github workflow in temurin-build https://github.com/adoptium/temurin-build/actions/runs/7172315110/job/19613059851. Locally was tested by Joe Braley. The PR won't affect jenkins job https://ci.adoptium.net/view/Test_grinder/job/Grinder/8444/console |
karianna
approved these changes
Jan 8, 2024
smlambert
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the cygwin check to correctly set LIB_DIR for cygwin os