Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vendor temurin in TKG #554

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

Hajer-Dahmani
Copy link

added vendor temurin in TKG

Fixes: #535

signed off by Hajer Dahmani hdahmani@andrew.cmu.edu

Fixes: adoptium#535

Signed-off-by: Hajer Dahmani <hdahmani@andrew.cmu.edu>
@karianna karianna requested review from smlambert and llxia May 26, 2024 23:11
@karianna
Copy link
Contributor

Not sure if eclipse and temurin should be treated as the same thing here

@smlambert
Copy link
Contributor

Not sure if eclipse and temurin should be treated as the same thing here

This PR handles cases when System.getProperty('java.vendor') returns Temurin. While Temurin is not actually a vendor, we need to handle the case when JDK builds actually return this value.

@smlambert smlambert merged commit 3ed8f8b into adoptium:master May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vendor Temurin in TKG
4 participants