Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaInfo.java: accept osArch i386 #585

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

zzambers
Copy link
Contributor

We face this error on linux x86:

...
System.getProperty('java.vm.name')=OpenJDK Server VM

System.getProperty('java.vendor')=Red Hat, Inc.

System.getProperty('os.name')=Linux

System.getProperty('os.arch')=i386

System.getProperty('java.fullversion')=null

Cannot determine System.getProperty('os.arch')=i386

make: *** [envDetect] Error 1
...

JavaInfo.java should accept i386 of os.arch system property. Seems like value of os.arch can be x86 or i386 on intel 32-bit, depending on platform. (See also code in Platform test class.)

@llxia
Copy link
Contributor

llxia commented Jul 15, 2024

Please provide Grinder link

@zzambers
Copy link
Contributor Author

zzambers commented Jul 15, 2024

x86-32_windows: OK
x86-64_linux: OK

Unfortunately, I cannot test linux x86 (32-bit) in grinder, as such Temurin build does not seem available. But I have tested this change locally (linux x86) and it fixed the issue.

@judovana
Copy link
Contributor

Can we please proceed with this? It is blocking all 32bit testing of ours.

@judovana
Copy link
Contributor

@smlambert @sophia-guo please?

@karianna karianna merged commit c3a8245 into adoptium:master Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants