Ignore variations when JVM_OPTIONS is set #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
reviewed
Sep 16, 2024
zzambers
force-pushed
the
jvm-opts-no-variants
branch
from
b8a33c5
to
165d1b0
Compare
sophia-guo
approved these changes
Sep 18, 2024
|
Cool. |
karianna
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset causes variations from
playlist.xmlto be ignored, ifJVM_OPTIONSenv. variable is set. See also: #611Motivation:
If
JVM_OPTIONSenv. var is set, jvm opstions for test target get overwritten (including ones set by variation). In this case, test target is still repeated for every variation. However variations no longer make any sense (with overwritten JVM options). It just causes confusion and makes test target run longer.Testing:
with
JVM_OPTIONSset: OK (multiple variations are NOT ran)without
JVM_OPTIONSset: OK (multiple variations are ran)