-
-
Notifications
You must be signed in to change notification settings - Fork 113
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fetch constants from api instead of having values hardcoded (#2787)
* Fetch constants from api instead of having values hardcoded * Prepare code for final version * Add dedicated tests * Correct tests * Correct two words path by using an underscore * Ajust final paths for new types (Architectures & OperatingSystems) --------- Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
- Loading branch information
1 parent
305e6dd
commit b69b24b
Showing
14 changed files
with
319 additions
and
144 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
src/hooks/__tests__/__snapshots__/fetchConstants.test.tsx.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html | ||
|
|
||
| exports[`fetchArches > URL is set correctly 1`] = ` | ||
| [ | ||
| { | ||
| "name": [ | ||
| { | ||
| "name": "mock_aarch64", | ||
| }, | ||
| { | ||
| "name": "mock_ppc64", | ||
| }, | ||
| { | ||
| "name": "mock_x64", | ||
| }, | ||
| ], | ||
| }, | ||
| ] | ||
| `; | ||
|
|
||
| exports[`fetchOses > URL is set correctly 1`] = ` | ||
| [ | ||
| { | ||
| "name": [ | ||
| { | ||
| "name": "mock_macos", | ||
| }, | ||
| { | ||
| "name": "mock_linux", | ||
| }, | ||
| { | ||
| "name": "mock_windows", | ||
| }, | ||
| ], | ||
| }, | ||
| ] | ||
| `; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import { renderHook, waitFor } from '@testing-library/react' | ||
| import { describe, expect, it, vi } from 'vitest' | ||
| import { fetchArches, fetchOses } from '../fetchConstants'; | ||
| import { mockArchesAPI, mockOsesAPI } from '../../__fixtures__/hooks'; | ||
| import axios from 'axios' | ||
| import MockAdapter from 'axios-mock-adapter'; | ||
|
|
||
| const mock = new MockAdapter(axios); | ||
|
|
||
| afterEach(() => { | ||
| vi.clearAllMocks(); | ||
| mock.reset(); | ||
| }); | ||
|
|
||
| afterAll(() => { | ||
| mock.restore(); | ||
| }); | ||
|
|
||
| describe('fetchArches', () => { | ||
| it('URL is set correctly', async () => { | ||
| const mockResponse = [mockArchesAPI()]; | ||
|
|
||
| mock.onGet().reply(200, mockResponse); | ||
| let spy = vi.spyOn(axios, "get"); | ||
|
|
||
| const { result } = renderHook(() => fetchArches(true)); | ||
|
|
||
| await waitFor(() => { | ||
| expect(result.current.length).toBeGreaterThan(0) | ||
| }, { interval: 1 }); | ||
| expect(spy).toHaveBeenCalledTimes(1) | ||
| expect(spy).toHaveBeenCalledWith( | ||
| "https://api.adoptium.net/v3/types/architectures" | ||
| ); | ||
| expect(result.current).toMatchSnapshot() | ||
| }) | ||
|
|
||
| it('Result is empty on error', async() => { | ||
| mock.onGet().reply(500); | ||
| let spy = vi.spyOn(axios, "get"); | ||
|
|
||
| const { result } = renderHook(() => fetchArches(true)); | ||
| await waitFor(() => { | ||
| expect(result.current.length).toBe(0) | ||
| }, { interval: 1 }); | ||
| expect(spy).toHaveBeenCalledTimes(1) | ||
| }) | ||
| }); | ||
|
|
||
| describe('fetchOses', () => { | ||
| it('URL is set correctly', async () => { | ||
| const mockResponse = [mockOsesAPI()]; | ||
|
|
||
| mock.onGet().reply(200, mockResponse); | ||
| let spy = vi.spyOn(axios, "get"); | ||
|
|
||
| const { result } = renderHook(() => fetchOses(true)); | ||
|
|
||
| await waitFor(() => { | ||
| expect(result.current.length).toBeGreaterThan(0) | ||
| }, { interval: 1 }); | ||
| expect(spy).toHaveBeenCalledTimes(1) | ||
| expect(spy).toHaveBeenCalledWith( | ||
| "https://api.adoptium.net/v3/types/operating_systems" | ||
| ); | ||
| expect(result.current).toMatchSnapshot() | ||
| }) | ||
|
|
||
| it('Result is empty on error', async() => { | ||
| mock.onGet().reply(500); | ||
| let spy = vi.spyOn(axios, "get"); | ||
|
|
||
| const { result } = renderHook(() => fetchOses(true)); | ||
| await waitFor(() => { | ||
| expect(result.current.length).toBe(0) | ||
| }, { interval: 1 }); | ||
| expect(spy).toHaveBeenCalledTimes(1) | ||
| }) | ||
| }); |
Oops, something went wrong.