Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 23 EA missing on the nightly builds page #3016

Closed
Peksa opened this issue Aug 12, 2024 · 8 comments
Closed

Java 23 EA missing on the nightly builds page #3016

Peksa opened this issue Aug 12, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@Peksa
Copy link

Peksa commented Aug 12, 2024

Describe the bug
Java 23 (EA) missing on the nightly builds page - only Java 21, 22 & 24 are visible

To Reproduce

  1. Visit https://adoptium.net/temurin/nightly/
  2. Click the version drop-down
  3. Note that 23 - EA is missing

Expected behavior
I expect to see a list with

24 - EA
23 - EA
22 
21 - LTS
etc..

Screenshots
image

Additional context
It's still possible to view the 23 nightly builds if you modify the URL to point at 23:
https://adoptium.net/temurin/nightly/?version=23

@Peksa Peksa added the bug Something isn't working label Aug 12, 2024
@xavierfacq
Copy link
Member

I'll take a look at this.

@xavierfacq xavierfacq self-assigned this Aug 12, 2024
@xavierfacq
Copy link
Member

xavierfacq commented Aug 16, 2024

First point: versions are retrieved from this endpoint: https://api.adoptium.net/v3/info/available_releases

No version 23 in the result
image

The VersionSelector component is used in the Nightly builds.

@xavierfacq
Copy link
Member

@gdams @johnoliver any idea why version 23 is not returned by the API?

@johnoliver
Copy link

So for ReleaseInfo.available_releases:

The versions for which adopt have produced a ga release

Since there have been no 23 GA releases it wont show up in the list. It would be possible to add a something for this such as:

  • Add ReleaseInfo.available_ea_releases which will have everything not just GA
  • Add a filter to the endpoint, i.e /v3/info/available_releases?release_type=ea to configure returning EA releases
  • Add a new endpoint /v3/info/available_ea_releases

In general I am not a fan of these, increasing the complexity/size of the API endpoints to support EA downloads is not a great ROI given how few people are interested in non-GA downloads. IMO the easiest would be simply for the website to assume that there are EA versions for versions between 16 and most_recent_feature_version, its a fairly safe assumption and even if it does not hold the user would just be presented with an empty list.

@karianna
Copy link
Contributor

karianna commented Sep 6, 2024

Is the simpler workaround here to have a static page / message to folks redirecting them to our slack for EA asks? I'm even hesitant to allow access to Jenkins here (a single script could spell doom)

@smlambert
Copy link
Contributor

Is the simpler workaround here to have a static page / message to folks redirecting them to our slack for EA asks? I'm even hesitant to allow access to Jenkins here (a single script could spell doom)

Perhaps msg to redirect to website https://adoptium.net/temurin/nightly/?version=23 and https://adoptium.net/temurin/nightly/?version=24 for EA builds ?

@smlambert
Copy link
Contributor

Ignore my comment above, was myopically responding to the comment without reading the full issue description!

@xavierfacq
Copy link
Member

Hello,

✔️ Problem is fixed since this morning: https://adoptium.net/fr/temurin/nightly/?version=23
Look at the PR for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants