Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3016] Assume that there are EA versions for versions between 16 and … #3059

Conversation

xavierfacq
Copy link
Member

@xavierfacq xavierfacq commented Sep 8, 2024

Description of change

This is a PR to answer to the issue #3016
It is a proposition to deal with missing version numbers returned by the API.

"assume that there are EA versions for versions between 16 and most_recent_feature_version"

Check here: https://deploy-preview-3059--eclipsefdn-adoptium.netlify.app/fr/temurin/nightly/?version=23

Checklist

  • npm test passes

Copy link

netlify bot commented Sep 8, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 3c7601d
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/66de9cc3e99e1600091a8816
😎 Deploy Preview https://deploy-preview-3059--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.47%. Comparing base (b363869) to head (3c7601d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3059   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          90       90           
  Lines        4951     4968   +17     
  Branches      618      624    +6     
=======================================
+ Hits         4925     4942   +17     
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq
Copy link
Member Author

Does somebody can re-run a full build/deploy to ensure everything is Ok? 🙏

@karianna
Copy link
Contributor

karianna commented Sep 8, 2024

@xavierfacq The netlify build seemed to be OK and almost produced the desiredv result (under nightly builds 24-EA is listed, but I'd have though that 23-EA should also exist?

@xavierfacq
Copy link
Member Author

@xavierfacq The netlify build seemed to be OK and almost produced the desiredv result (under nightly builds 24-EA is listed, but I'd have though that 23-EA should also exist?

You are right so I did the fix, so that all missing version will be name 'XX - EA'.

…github.com:xavierfacq/adoptium.net into 3016-java-23-ea-missing-on-the-nightly-builds-page
@xavierfacq xavierfacq marked this pull request as ready for review September 9, 2024 07:05
@karianna karianna merged commit 48fec4e into adoptium:main Sep 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants