Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons in Releases page to go to Archive AND Nightly Builds #2104

Conversation

xavierfacq
Copy link
Member

Description of change

As well as in Archive page and Nightly Builds page, I suggest to add both buttons in the bottom of the Latest Releases page, by adding the link to Nightly Builds.

  • add button to Nightly Builds
  • fix css (btn btn)

Checklist

  • npm test passes

image

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 9df691b
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/64dc92692d1a350008089c54
😎 Deploy Preview https://deploy-preview-2104--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xavierfacq
Copy link
Member Author

@gdams I don't understand why the "CI / Run CI" task failed, is it a problem ? 🙏

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2104 (9df691b) into main (9362c64) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2104   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          85       85           
  Lines        6199     6202    +3     
  Branches      509      509           
=======================================
+ Hits         6147     6150    +3     
  Misses         52       52           
Files Changed Coverage Δ
src/pages/temurin/releases.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@karianna karianna merged commit 6fb85fd into adoptium:main Aug 17, 2023
11 checks passed
@xavierfacq xavierfacq deleted the add_buttons_to_release_archive_and_nightly_builds branch September 7, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants