-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[adoptium.net-1508] Release notes should initially be sorted by priority & component #2181
[adoptium.net-1508] Release notes should initially be sorted by priority & component #2181
Conversation
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2181 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 87 87
Lines 6420 6440 +20
Branches 539 544 +5
=======================================
+ Hits 6368 6388 +20
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@xavierfacq Can we get the code coverage back up for this change in terms of tests? |
Co-authored-by: George Adams <george.adams@microsoft.com>
Description of change
This PR is a small improvement for the point 4 of the issue #1508
Release notes are now initially sorted by priority & component.
I have also reduced sort type to ASC et DESC (no more "null" order!)
Note that reversing the order by priority (DESC) do not reverse the order of the "component" column.
A good test is : https://deploy-preview-2181--eclipsefdn-adoptium.netlify.app/fr/temurin/release-notes/?version=jdk-17.0.8+7
Checklist
npm test
passes