Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checklist link from release banner template #2449

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

sxa
Copy link
Member

@sxa sxa commented Nov 20, 2023

As discussed in retrospective, we should not include the checklist in the template, so I'm adjusting the commented out section that included it for the October release to discourage it from being added

Ref: adoptium/temurin#4 (comment)

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 84aa1dd
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/655b71230284c70008028e79
😎 Deploy Preview https://deploy-preview-2449--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c01a82) 99.20% compared to head (84aa1dd) 99.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2449      +/-   ##
==========================================
- Coverage   99.20%   99.20%   -0.01%     
==========================================
  Files          87       87              
  Lines        6542     6541       -1     
  Branches      552      552              
==========================================
- Hits         6490     6489       -1     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdams gdams merged commit 97925ab into adoptium:main Nov 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants