Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.adoc as there is no -SNAPSHOT- in the URL. #2719

Closed
wants to merge 4 commits into from

Conversation

Sarkie
Copy link

@Sarkie Sarkie commented Mar 15, 2024

Description of change

Update index.adoc as there is no -SNAPSHOT- in the URL.

Checklist

  • [x ] documentation is changed or added (if applicable)
  • [ x] contribution guidelines followed here

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 9c27480
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6604159ae457c00008aef3ff
😎 Deploy Preview https://deploy-preview-2719--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (2218887) to head (9c27480).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2719   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          88       88           
  Lines        6759     6759           
  Branches      584      584           
=======================================
  Hits         6708     6708           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karianna
Copy link
Contributor

@Sarkie Are you able ot sign the Eclipse CLA?

@Sarkie
Copy link
Author

Sarkie commented Mar 18, 2024

@karianna Sorry, is there an SOP to do that? thanks

@karianna
Copy link
Contributor

@Sarkie
Copy link
Author

Sarkie commented Mar 20, 2024

Let me ask my legal. I think it'll be fine

@jiekang
Copy link
Contributor

jiekang commented Mar 27, 2024

FYI, I created this issue for the problem being fixed here:

#2740

@Sarkie
Copy link
Author

Sarkie commented Mar 27, 2024

It seems I can't sign it.
That's ok.
Happy to have it fixed regardless.

@xavierfacq
Copy link
Member

It seems I can't sign it. That's ok. Happy to have it fixed regardless.

Ok I'll take care of that

@xavierfacq
Copy link
Member

Modifications have been reported in this PR #2742

@xavierfacq xavierfacq closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants