Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instruction to reflect Homebrew changes #2831

Merged
merged 4 commits into from
May 1, 2024

Conversation

RadekCap
Copy link
Contributor

Description of change

Relates #2817
This change reflects changed behavior on the brew.

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit cccd3d3
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/66313c4323e644000977834d
😎 Deploy Preview https://deploy-preview-2831--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.25%. Comparing base (b69b24b) to head (cccd3d3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2831   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          89       89           
  Lines        6851     6851           
  Branches      602      602           
=======================================
  Hits         6800     6800           
  Misses         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karianna karianna requested a review from gdams April 30, 2024 21:01
@karianna
Copy link
Contributor

I wonder if we do need to also add some instructions on how to remove the old cask references and move to the new ones. Is that something you could add as a callout?

@RadekCap
Copy link
Contributor Author

RadekCap commented May 1, 2024

:) I don't know where are old cask references stored. We even haven't decided what about upgrade. Do we need to cover it somewhere etc.

This PR is about an update to our documentation to the currently working solution.

It would be nice to find someone who has more experience with homebrew maybe.

@karianna karianna merged commit 378d99e into adoptium:main May 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants