Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.adoc #2906

Closed
wants to merge 1 commit into from
Closed

Update index.adoc #2906

wants to merge 1 commit into from

Conversation

phil69210
Copy link

Added "sudo" before "tee" to make these commands run fine.

Description of change

Checklist

  • npm test passes
  • [ x] documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 70e971d
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/666a3d31e9550400085dbd32
😎 Deploy Preview https://deploy-preview-2906--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (cda5d70) to head (70e971d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2906   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          90       90           
  Lines        6956     6956           
  Branches      608      608           
=======================================
  Hits         6917     6917           
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karianna
Copy link
Contributor

@gdams & @sxa - I'm in two minds about this, I know we have the guidance at the top but we still get a lot of support tickets from folks who CnP - thoughts on accepting this?

Added "sudo"  before "tee" to make these commands run fine.
@sxa
Copy link
Member

sxa commented Jun 13, 2024

@gdams & @sxa - I'm in two minds about this, I know we have the guidance at the top but we still get a lot of support tickets from folks who CnP - thoughts on accepting this?

I'm personally 👎🏻 on this. Personally in many cases where I'm doing stuff like this I'm either already running as root or running in a minimal environment which may not have sudo installed, so I feel that forcing sudo into the command in the instructions is not the best way to approach this.

Further reasoning is in the PR where I removed the sudo parts from the commands, which this would revert: #477

@karianna
Copy link
Contributor

@phil69210 I'm afraid we won't be takling this patch on but appreciate the efforts to make the process more user friendly!

@karianna karianna closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants