Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Reenable JdiTest #1171

Closed
wants to merge 1 commit into from
Closed

WIP: Reenable JdiTest #1171

wants to merge 1 commit into from

Conversation

andrew-m-leonard
Copy link
Contributor

Signed-off-by: andrew-m-leonard andrew_m_leonard@uk.ibm.com

Signed-off-by: andrew-m-leonard <andrew_m_leonard@uk.ibm.com>
@karianna karianna added the bug label Jun 7, 2019
@andrew-m-leonard
Copy link
Contributor Author

Depends on STF issue being fixed: adoptium/STF#65

@smlambert
Copy link
Contributor

@andrew-m-leonard - are you currently working on a fix for adoptium/STF#65 ?

@andrew-m-leonard
Copy link
Contributor Author

Not at this minute, but it is in my "todo" as it blocks reenabling jditest for jdk8

@andrew-m-leonard
Copy link
Contributor Author

i'm thinking isIBMJvm() should only be for IBMSDK, but need to check the other 3 places that use it first...

@andrew-m-leonard
Copy link
Contributor Author

mmm, may have to do some more work on JdiTest... it passes on XLinux, but
fails on Mac....

@smlambert smlambert changed the title Reenable JdiTest WIP: Reenable JdiTest Jun 7, 2019
@smlambert
Copy link
Contributor

Setting to WIP so its not inadvertently merged before its ready.

@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Jun 17, 2019

OpenJDK community currently state JDI is not specified as thread-safe...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants