Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoongArch64 support locally test #4168

Merged

Conversation

Panxuefeng-loongson
Copy link
Contributor

Due to the lack of machine resources, this PR is only used to support LoongArch locally test.

@smlambert
Copy link
Contributor

Thanks @Panxuefeng-loongson - I see you have PRs in STF and TKG too.

I will refer you to this document: https://github.com/adoptium/aqa-tests/wiki/Adding-AQAvit-support-for-a-New-Platform

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Panxuefeng-loongson
Copy link
Contributor Author

@theaoqi I would like you confirm the change

@Panxuefeng-loongson
Copy link
Contributor Author

Thanks @Panxuefeng-loongson - I see you have PRs in STF and TKG too.

I will refer you to this document: https://github.com/adoptium/aqa-tests/wiki/Adding-AQAvit-support-for-a-New-Platform

Thank you for the useful information! I am still a newcomer to the community, so I will study this wiki carefully. We have submitted PRs in temurin-build[1], ci-jenkins-pipelines[2], aqa-tests and associated repo. Can you please let me know if there are any other repositories that need to add the Loongson code. In addition to this, I am trying to make the Loonson machine resources available to the community infrastructure, I have created an issue[3] and expressed Loongson's desire to provide machine resources to participate in community work more deeply. Providing machine resources to the community is a priority for me in the near future. Is there any relevant documentation reference?

[1] adoptium/temurin-build#3134
[2] adoptium/ci-jenkins-pipelines#493
[3] adoptium/infrastructure#2806

@smlambert
Copy link
Contributor

re: #4168 (comment) - having machines to test these changes on will be excellent. I see you correctly created an issue in the infrastructure repository to get that process started, thanks!

@theaoqi
Copy link

theaoqi commented Nov 29, 2022

@theaoqi I would like you confirm the change

I am not an expert of this repo, but the Loongson part seems trivial and fine to me.

@Panxuefeng-loongson
Copy link
Contributor Author

ping

@smlambert
Copy link
Contributor

While there is nothing technically wrong with the changes in this PR, they are not sufficient to "locally support testing" on a new platform.

As per https://github.com/adoptium/aqa-tests/wiki/Adding-AQAvit-support-for-a-New-Platform, there would need to be changes in TKG repository as well, and to support testing on Jenkins, an update to openjdk_tests file is also needed. I will merge this one as is, but know that if machines are available to test changes on, we can follow up with other PRs.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, with the understanding that other PRs will follow in order to fully support local testing.

@smlambert smlambert merged commit fa87a69 into adoptium:master Dec 22, 2022
@Panxuefeng-loongson Panxuefeng-loongson deleted the supportForLoongArch64 branch December 23, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants