-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoongArch64 support locally test #4168
LoongArch64 support locally test #4168
Conversation
Thanks @Panxuefeng-loongson - I see you have PRs in STF and TKG too. I will refer you to this document: https://github.com/adoptium/aqa-tests/wiki/Adding-AQAvit-support-for-a-New-Platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@theaoqi I would like you confirm the change |
Thank you for the useful information! I am still a newcomer to the community, so I will study this wiki carefully. We have submitted PRs in temurin-build[1], ci-jenkins-pipelines[2], aqa-tests and associated repo. Can you please let me know if there are any other repositories that need to add the Loongson code. In addition to this, I am trying to make the Loonson machine resources available to the community infrastructure, I have created an issue[3] and expressed Loongson's desire to provide machine resources to participate in community work more deeply. Providing machine resources to the community is a priority for me in the near future. Is there any relevant documentation reference? [1] adoptium/temurin-build#3134 |
re: #4168 (comment) - having machines to test these changes on will be excellent. I see you correctly created an issue in the infrastructure repository to get that process started, thanks! |
I am not an expert of this repo, but the Loongson part seems trivial and fine to me. |
ping |
While there is nothing technically wrong with the changes in this PR, they are not sufficient to "locally support testing" on a new platform. As per https://github.com/adoptium/aqa-tests/wiki/Adding-AQAvit-support-for-a-New-Platform, there would need to be changes in TKG repository as well, and to support testing on Jenkins, an update to openjdk_tests file is also needed. I will merge this one as is, but know that if machines are available to test changes on, we can follow up with other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging, with the understanding that other PRs will follow in order to fully support local testing.
Due to the lack of machine resources, this PR is only used to support LoongArch locally test.