Enable CryptoTests on jdk19+

[zzambers]

CryptoTests can be enabled on jdk19+.
Issue has been fixed by: rh-openjdk/CryptoTest#31

[zzambers]

Tests Passed:
JDK19: https://ci.adoptium.net/job/Grinder/7032/
JDK20: https://ci.adoptium.net/job/Grinder/7034/

[llxia]

CryptoTests did not run green for openj9. I do not think we should enable this on openj9 JDK19+ atm.
https://github.com/eclipse-openj9/openj9/issues?q=is%3Aissue+is%3Aopen+CryptoTests

@pshipton do you have any preference?

[pshipton]

I'd prefer we don't enable Crypto tests for OpenJ9 until they are working. They fail consistently on Windows due to access denied eclipse-openj9/openj9#16710. It would be wonderful if we could disable OpenJ9 Crypto tests on Windows across all versions.

They fail sometimes on Linux machines which don't have a proper /dev/random eclipse-openj9/openj9#16720. I don't mind the occasional failure on Linux, if we enable them for Java 19 there.

[zzambers]

@llxia @pshipton thanks for pointing out openj9 issues, I was not aware of some of them, I'll take a look.

[pshipton]

I've been assuming they are OpenJ9 machine issues. We'd like to get the bad Linux machines updated, the instructions seems clear, but haven't had the resources to do it yet. For Windows, we aren't sure what we need to update on the machines to avoid the access denied problems. We've tried a couple of things, but didn't get it working.

[zzambers]

CryptoTest being disabled on JDK19+ does not seem to be connected to openj9 issues.

Problems there seem to be infra related and not specific to JDK19+. (Blocking /dev/random causing timeouts, "access denied" in windows MSCAPI)

[smlambert]

Instead of deleting this block of code, please leave it and add
<impl>openj9</impl>
after the <version>19+</version> section

which effectively means it will remain disabled only for that implementation, and not for hotspot implementations.

[zzambers]

@smlambert Updated

JDK19 linux x86_64: OK
https://ci.adoptium.net/view/Test_grinder/job/Grinder/7293/