Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename openjdkbinary folder to jdkbinary #4837

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Oct 26, 2023

related: backlog/issues/1243

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Oct 26, 2023

jdk_math: https://ci.adoptium.net/view/Test_grinder/job/Grinder/7925/

10:12:52  -jdk:"/home/jenkins/workspace/Grinder/jdkbinary/j2sdk-image" \

floatSanityTests: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/2999/

00:01:11.180  TEST_JDK_HOME=/home/jenkins/workspace/Grinder/jdkbinary/j2sdk-image

@llxia
Copy link
Contributor Author

llxia commented Oct 26, 2023

FYI @JasonFengJ9 @pshipton

@JasonFengJ9
Copy link
Contributor

There are a few openjdkbinary references in other repos:
https://github.com/adoptium/aqa-test-tools
https://github.com/adoptium/temurin-build
Should those be updated as well?

@llxia
Copy link
Contributor Author

llxia commented Oct 26, 2023

Thanks @JasonFengJ9

@llxia
Copy link
Contributor Author

llxia commented Oct 27, 2023

#4837, adoptium/temurin-build#3517 and adoptium/run-aqa#191 should be merged together with this PR.

Copy link
Contributor

@JasonFengJ9 JasonFengJ9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified in a few grinders, looks good.

Thanks @llxia

@llxia llxia marked this pull request as ready for review October 30, 2023 12:58
@llxia llxia requested a review from smlambert October 30, 2023 12:58
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to merge this alongside the temurin-build and other repo changes? I will leave it until others are reviewed and ready to also merge.

@sophia-guo sophia-guo merged commit 06f5612 into adoptium:master Oct 31, 2023
3 checks passed
llxia added a commit to llxia/aqa-tests that referenced this pull request Nov 22, 2023
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
llxia added a commit to llxia/aqa-tests that referenced this pull request Nov 22, 2023
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
pshipton pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants