Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gmake instead of make on AIX to avoid aqa-tests issue 5542 #5550

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

adamfarley
Copy link
Contributor

...where make fails with this error:
make: Dependency line needs colon or double colon operator.

Resolves #5542

@adamfarley
Copy link
Contributor Author

Testing here: https://ci.adoptium.net/job/Grinder/10818/

@adamfarley
Copy link
Contributor Author

Yep, works fine. Asking for reviews and merge.

@Haroon-Khel
Copy link
Contributor

This works because on our AIX machines /usr/bin/gmake points to /opt/freeware/bin/make. Equally a solution would be to provide the full path to /opt/freeware/bin/make. I'll check on all of our machines to see if /usr/bin/gmake points to /opt/freeware/bin/make before approving

@smlambert
Copy link
Contributor

smlambert commented Sep 4, 2024

Remembering that other companies use our scripts and playbooks, and that we must also support command line testing (outside of Jenkins runs), so putting a fix into a Jenkins groovy script does not necessarily resolve the issue for running via command line. EDIT: given this is a case relating to running in parallel in Jenkins, perhaps so.

@Haroon-Khel - is that mapping of /usr/bin/gmake to /opt/freeware/bin/make in the AIX playbooks?

@Haroon-Khel
Copy link
Contributor

@Haroon-Khel - is that mapping of /usr/bin/gmake to /opt/freeware/bin/make in the AIX playbooks?

The specific creation of that symlink is not in the playbooks. It might be that it is created during the installation of make

I'll check on all of our machines to see if /usr/bin/gmake points to /opt/freeware/bin/make before approving

/usr/bin/gmake points to /opt/freeware/bin/make on all of our AIX machines

...where make fails with this error:
make: Dependency line needs colon or double colon operator.

Signed-off-by: Adam Farley <adfarley@redhat.com>
@Haroon-Khel
Copy link
Contributor

See #5542 (comment)

A solution which avoids changing the test scripts is to add PATH=/opt/freeware/bin:$PATH to the jenkins config of our AIX machines. After making this change to test-osuosl-aix72-ppc64-4 and rebuilding its failing sanity system job it looks like it finds the right make

https://ci.adoptium.net/job/Test_openjdk21_hs_sanity.system_ppc64_aix/140/console

@smlambert
Copy link
Contributor

@adamfarley
Copy link
Contributor Author

Non-AIX Grinder: https://ci.adoptium.net/view/Test_grinder/job/Grinder/10994

Looks like it correctly identified the non-AIX platform and used make instead of gmake.

01:05:20  + make genParallelList TEST=jdk_math TEST_TIME=120 NUM_MACHINES=

Requesting review and merge.

@smlambert smlambert merged commit 886db81 into adoptium:master Oct 8, 2024
2 checks passed
@adamfarley
Copy link
Contributor Author

Thanks @ShelleyLambert :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIX: Testing fails because it cannot "make genParallelList"
4 participants