-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gmake instead of make on AIX to avoid aqa-tests issue 5542 #5550
Conversation
Testing here: https://ci.adoptium.net/job/Grinder/10818/ |
Yep, works fine. Asking for reviews and merge. |
This works because on our AIX machines |
Remembering that other companies use our scripts and playbooks, and that we must also support command line testing (outside of Jenkins runs), so putting a fix into a Jenkins groovy script does not necessarily resolve the issue for running via command line. EDIT: given this is a case relating to running in parallel in Jenkins, perhaps so. @Haroon-Khel - is that mapping of /usr/bin/gmake to /opt/freeware/bin/make in the AIX playbooks? |
The specific creation of that symlink is not in the playbooks. It might be that it is created during the installation of make
|
...where make fails with this error: make: Dependency line needs colon or double colon operator. Signed-off-by: Adam Farley <adfarley@redhat.com>
3f9211a
to
1ea3bb1
Compare
See #5542 (comment) A solution which avoids changing the test scripts is to add PATH=/opt/freeware/bin:$PATH to the jenkins config of our AIX machines. After making this change to test-osuosl-aix72-ppc64-4 and rebuilding its failing sanity system job it looks like it finds the right make https://ci.adoptium.net/job/Test_openjdk21_hs_sanity.system_ppc64_aix/140/console |
Non-AIX Grinder: https://ci.adoptium.net/view/Test_grinder/job/Grinder/10994 |
Looks like it correctly identified the non-AIX platform and used make instead of gmake.
Requesting review and merge. |
Thanks @ShelleyLambert :) |
...where make fails with this error:
make: Dependency line needs colon or double colon operator.
Resolves #5542