-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude windows beans due to headless detection JDK-8336862 #5617
Merged
sophia-guo
merged 4 commits into
adoptium:master
from
andrew-m-leonard:exclude_windows_beans
Sep 17, 2024
Merged
Exclude windows beans due to headless detection JDK-8336862 #5617
sophia-guo
merged 4 commits into
adoptium:master
from
andrew-m-leonard:exclude_windows_beans
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
smlambert
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace #5616 with https://bugs.openjdk.org/browse/JDK-8336862 as the referenced issue in each of the added lines.
In the case where there is an upstream issue, we prefer to use it for the exclusion, in that way, we do not have to leave a duplicate issue (aqa-tests/5616) open in our repo.
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
smlambert
approved these changes
Sep 17, 2024
sophia-guo
approved these changes
Sep 17, 2024
andrew-m-leonard
added a commit
to andrew-m-leonard/aqa-tests
that referenced
this pull request
Sep 17, 2024
…#5617) * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> --------- Signed-off-by: Andrew Leonard <anleonar@redhat.com>
andrew-m-leonard
added a commit
to andrew-m-leonard/aqa-tests
that referenced
this pull request
Sep 17, 2024
…#5617) * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> --------- Signed-off-by: Andrew Leonard <anleonar@redhat.com>
This was referenced Sep 17, 2024
smlambert
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Exclude MBCS_Tests_formatter_zh_TW_linux and MBCS_Tests_i18n_ko_KR_linux for all Linux (#5614) Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude windows beans due to headless detection JDK-8336862 (#5617) * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> --------- Signed-off-by: Andrew Leonard <anleonar@redhat.com> --------- Signed-off-by: Andrew Leonard <anleonar@redhat.com>
smlambert
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Exclude MBCS_Tests_formatter_zh_TW_linux and MBCS_Tests_i18n_ko_KR_linux for all Linux (#5614) Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude windows beans due to headless detection JDK-8336862 (#5617) * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> * Exclude java beans openjdk tests due to JDK-8336862 Signed-off-by: Andrew Leonard <anleonar@redhat.com> --------- Signed-off-by: Andrew Leonard <anleonar@redhat.com> --------- Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude Windows beans tests that fail with headless detection issue "application does not have desktop access"
ref: https://bugs.openjdk.org/browse/JDK-8336862