Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quote around .zip #5665

Merged
merged 1 commit into from
Oct 9, 2024
Merged

add quote around .zip #5665

merged 1 commit into from
Oct 9, 2024

Conversation

prodroy89
Copy link
Contributor

Having build unzip issues due to nested zip in jenkins submission on windows platforms.

Fixes is given here by *adding quote around .zip:- https://github.com/prodroy89/aqa-tests/blob/8af20858dcfa4480057f6075b3c7abd743098db3/get.sh#L313

Signed-off-by: Prodip Roy prodroy89@in.ibm.com

@prodroy89
Copy link
Contributor Author

Ref. Link for nested zip issues :-
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/24128/

Ref. Links after adding quote around .zip:-
Single runs link:- https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/24115/
Grinder runs link:- https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/24394/

Thanks.

@llxia
Copy link
Contributor

llxia commented Oct 7, 2024

Thanks for updating the commit message. However, the PR title has not changed. Please update it.

For future reference, please do not submit PR via GUI and refer to https://github.com/adoptium/aqa-tests/blob/master/Contributing.md for how to contribute to aqa-tests repo.

@prodroy89
Copy link
Contributor Author

Hi @llxia, sure, thank you so much.

@prodroy89 prodroy89 changed the title Having build unzip issues due to nested zip in jenkins submission on windows platforms. added single quote around .zip Oct 9, 2024
@prodroy89
Copy link
Contributor Author

Hi @llxia , I have done changes title as well, can you please check once? Thanks.

@prodroy89 prodroy89 changed the title added single quote around .zip add quote around .zip Oct 9, 2024
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prodroy89

@llxia llxia merged commit 23e34df into adoptium:master Oct 9, 2024
2 checks passed
@prodroy89
Copy link
Contributor Author

Thanks @llxia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants