Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SHA check function to TKG #5819

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

sophia-guo
Copy link
Contributor

Close #5818

@sophia-guo
Copy link
Contributor Author

Depends adoptium/TKG#651

@sophia-guo
Copy link
Contributor Author

@sophia-guo sophia-guo force-pushed the sha branch 3 times, most recently from b264e31 to d4580a6 Compare December 16, 2024 17:28
@sophia-guo sophia-guo force-pushed the sha branch 3 times, most recently from ede8d5a to 2145bef Compare December 20, 2024 23:43
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

get.sh Outdated
Comment on lines 664 to 667
mkdir -p ../git-backup
mv .git ../git-backup
rm -rf *
mv ../git-backup .git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we should move .git file around. Can we move it into the subfolder? In this case, it should be functional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.git is not moved around. .git keeps in openj9/.git and all others under openj9 are removed. Same for all available vendors repo as vendor*/.git.
aqa-tests/functional may also have other vendor's test material. For example eclispe adoptium https://github.com/adoptium/temurin-build/tree/master/test/functional/ so it's not good to move .git to aqa-tests/functional

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To delete everything but .git, I would prefer to use git cmd https://stackoverflow.com/questions/22339837/linux-command-to-delete-all-files-except-git-folder

git rm -rf .
git clean -fxd

also, rm -rf * is dangerous to use.

Copy link
Contributor Author

@sophia-guo sophia-guo Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karianna karianna requested a review from llxia January 15, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track all test materials or frameworks sha info
3 participants