Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency verification and lock files #152

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johnoliver
Copy link
Contributor

No description provided.

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed one the dependencies is jenkins-core:2.85. What are the implications of this? Does it mean that the build will not work on other version of Jenkins? Is there an issue with some background info regarding this change?

@johnoliver
Copy link
Contributor Author

@AdamBrousseau if jenkins make a breaking change then yes, but this PR is not setting this version, that value was set some time ago at:

compile group: 'org.jenkins-ci.main', name: 'jenkins-core', version: '2.85', ext: 'pom'

@karianna karianna modified the milestones: May 2021, June 2021 Jun 6, 2021
AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Apr 24, 2023
Temporarily disable system tests for FIPS
@andrew-m-leonard
Copy link
Contributor

this has been stale for over a year, converting to "draft", if no longer needed please close.

@andrew-m-leonard andrew-m-leonard marked this pull request as draft April 3, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants